[vlc-devel] [PATCH 21/26] decoder: allow decoders to set their output vlc_video_context

[Steve Lhomme]

On 2019-09-23 15:53, Thomas Guillem wrote:
> 
> 
> On Fri, Sep 20, 2019, at 16:28, Steve Lhomme wrote:
>> ---
>>   include/vlc_codec.h         |  3 +++
>>   src/input/decoder_helpers.c | 14 ++++++++++++++
>>   2 files changed, 17 insertions(+)
>>
>> diff --git a/include/vlc_codec.h b/include/vlc_codec.h
>> index bd13a024207..098ffb21760 100644
>> --- a/include/vlc_codec.h
>> +++ b/include/vlc_codec.h
>> @@ -111,6 +111,9 @@ struct decoder_t
>>       /* Output format of decoder/packetizer */
>>       es_format_t         fmt_out;
>>   
>> +    /* Video context used by picture coming out of the decoder */
>> +    struct vlc_video_context  *vctx_out;
> 
> Why not passing this video context as a decoder_UpdateVideoOutput() argument ?

So far I kept it in the decoder_t in case I need it. But looking at my 
(more or less) complete code it can be done without storing it. So I'll 
do that. It will be the responsibility of each VA/NVDEC to pass 
it/release it.