[vlc-devel] [PATCH 0/2] macosx: widen stored playback position for longer videos

[Thomas Guillem]

On Tue, Sep 24, 2019, at 02:02, Mikhail Gusarov wrote:
> Any comments?

Yes, that is clever.

The windows UI (Qt) is now using the MediaLibrary to do that kind of work. The macOS UI will soon do the same thing.
The save/restore position is not yet merged on the MediaLibrary, cf the proposed patch here: https://mailman.videolan.org/pipermail/vlc-devel/2019-September/127614.html

I think your patch should be merged on the player/medialib part (after Hugo's work is merged).

> 
> On 19 Sep 2019, at 16:33, Mikhail Gusarov wrote:
> 
> > Existing logic of storing playback position for macOS excludes 
> > positions within
> > first/last 5%.
> >
> > This heuristic is fine for short videos, but for a longer one, say a 
> > 6-hour one,
> > it means the position is not stored for the first/last 18 minutes, 
> > which is a
> > nuisance.
> >
> > This change adds an upper limit for the size of excluded positions.
> >
> > Compile-tested against master only due to UI breakage. Similar patch 
> > tested
> > against 3.0 and works fine.
> >
> > Mikhail Gusarov (2):
> >   macosx: extract a helper to test if the position should be saved
> >   macosx: widen stored playback position for longer videos
> >
> >  .../VLCPlaybackContinuityController.m         | 33 
> > ++++++++++++++++---
> >  1 file changed, 29 insertions(+), 4 deletions(-)
> >
> > -- 
> > 2.22.0
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel