[vlc-devel] [vlc-commits] posix: rely on F_DUPFD_CLOEXEC

[Rémi Denis-Courmont]

And? It removes dead code. If the code weren't dead, it wouldn't compile. And yes I did check the build bot logs and technical documentation beforehand.

Le 24 septembre 2019 10:20:55 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 2019-09-23 18:15, Rémi Denis-Courmont wrote:
>> Hi,
>> 
>> Excuse me? How does this change macOS code?
>
>You even wrote "macOS" in the commit log yourself:
>
>This was added in POSIX.2008 and thus missing on MacOS < 10.7.
>But those old versions are no longer supported since VLC 3.0.
>
>> Le 23 septembre 2019 13:44:54 GMT+03:00, Steve Lhomme
><robux4 at ycbcr.xyz> a écrit :
>>> On 2019-09-23 11:28, Rémi Denis-Courmont wrote:
>>>> I am sad to see that you are still attacking me after other people
>>> have done the same thing, trivial changes to the core, and then
>claim
>>> the contrary.
>>>
>>> I know I pushed 054296854082e70580d3bcf85d77d7ebc3f6e800 which is
>just
>>> a
>>> comment change and I proposed in July (in a big patchset).
>>>
>>> As for the trivial part, given you change macOS code and we all know
>>> you
>>> didn't verify it on that platform, it would be at least good to ask
>>> devs
>>> on that platform that the changes are OK. For example Apple may
>decide
>>> to (not) support something and later change its mind.
>>>
>>>> I don't have advice on code review from somebody that knowingly
>>> merged a broken UI rework in spite of objections, and still is
>>> inhibiting the development process 6 months later.
>>>>
>>>> Le 23 septembre 2019 11:23:43 GMT+03:00, Thomas Guillem
>>> <thomas at gllm.fr> a écrit :
>>>>> Hello,
>>>>>
>>>>> I'm sad to see that this didn't went through the mailing list. I
>>> think
>>>>> that every one now is doing this extra effort.
>>>>>
>>>>> Nevertheless, I'm OK with this set.
>>>>>
>>>>> On Sat, Sep 21, 2019, at 11:49, Rémi Denis-Courmont wrote:
>>>>>> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> |
>Sat
>>>>> Sep
>>>>>> 21 11:57:19 2019 +0300|
>[95041019b09a5ecd8c5343721a136b349590be92]
>>> |
>>>>>> committer: Rémi Denis-Courmont
>>>>>>
>>>>>> posix: rely on F_DUPFD_CLOEXEC
>>>>>>
>>>>>> This was added in POSIX.2008 and thus missing on MacOS < 10.7.
>>>>>> But those old versions are no longer supported since VLC 3.0.
>>>>>>
>>>>>>>
>>>>>
>>>
>http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=95041019b09a5ecd8c5343721a136b349590be92
>>>>>> ---
>>>>>>
>>>>>>    src/posix/filesystem.c | 7 -------
>>>>>>    1 file changed, 7 deletions(-)
>>>>>>
>>>>>> diff --git a/src/posix/filesystem.c b/src/posix/filesystem.c
>>>>>> index 2ac9c1187e..0ba1a37957 100644
>>>>>> --- a/src/posix/filesystem.c
>>>>>> +++ b/src/posix/filesystem.c
>>>>>> @@ -185,14 +185,7 @@ char *vlc_getcwd (void)
>>>>>>    
>>>>>>    int vlc_dup (int oldfd)
>>>>>>    {
>>>>>> -#ifdef F_DUPFD_CLOEXEC
>>>>>>        return fcntl (oldfd, F_DUPFD_CLOEXEC, 0);
>>>>>> -#else
>>>>>> -    int newfd = dup (oldfd);
>>>>>> -    if (newfd != -1)
>>>>>> -        vlc_cloexec(oldfd);
>>>>>> -    return newfd;
>>>>>> -#endif
>>>>>>    }
>>>>>>    
>>>>>>    int vlc_pipe (int fds[2])
>>>>>>
>>>>>> _______________________________________________
>>>>>> vlc-commits mailing list
>>>>>> vlc-commits at videolan.org
>>>>>> https://mailman.videolan.org/listinfo/vlc-commits
>>>>>>
>>>>> _______________________________________________
>>>>> vlc-devel mailing list
>>>>> To unsubscribe or modify your subscription options:
>>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>>
>>>> -- 
>>>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>>> excuser ma brièveté.
>>>>
>>>>
>>>> _______________________________________________
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser ma brièveté.
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190924/0752f847/attachment.html>