[vlc-devel] [PATCH 0/2] macosx: widen stored playback position for longer videos

[Hugo Beauzée-Luyssen]

On Tue, Sep 24, 2019, at 11:24 AM, Konstantin Pavlov wrote:
> Bonjour Thomas,
> 
> On Tue, Sep 24, 2019 at 08:32:52AM +0200, Thomas Guillem wrote:
> > On Tue, Sep 24, 2019, at 02:02, Mikhail Gusarov wrote:
> > > Any comments?
> > 
> > Yes, that is clever.
> > 
> > The windows UI (Qt) is now using the MediaLibrary to do that kind of work. The macOS UI will soon do the same thing.
> > The save/restore position is not yet merged on the MediaLibrary, cf the proposed patch here: https://mailman.videolan.org/pipermail/vlc-devel/2019-September/127614.html
> > 
> > I think your patch should be merged on the player/medialib part (after Hugo's work is merged).
> 

I just merged that code, the part relevant to your patch is there: https://code.videolan.org/videolan/vlc/blob/master/src/player/medialib.c#L139

AFAICS the issue you described is still there, it would be really cool if you could apply the same logic change over there, and feel free to reach out if something isn't clear with the player or media library code :)

> Unrelated to 4.0 medialibrary changes, this probably is a good candidate
> for 3.0 branch as well.

Very good point, if the macOS people agree I think this can be merged to the 3.0 branch directly

> 
> -- 
> VideoLAN, Vice President
> www.videolan.org
> +7 926 165 45 31
> @cryothresh
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr