[vlc-devel] [PATCH] Add support for AMT

[Rémi Denis-Courmont]

Le keskiviikkona 25. syyskuuta 2019, 6.25.11 EEST Natalie Landsberg a écrit :
> Updated amt.c with all changes made in this branch:
> https://code.videolan.org/tguillem/vlc/commits/amt/8
> 
> This should address the majority of comments from last submission.
> Primarily cleaning up the code with Thomas' help to better fit VLC's code
> style.
> 
> One note:
> recvmsg() had to be used in BlockUDP() instead of recv() because VLC crashes
> otherwise. udp.c uses recvmsg() as well.

No, udp.c does not use recvmsg() because of "crashes".

udp.c uses recvmsg() because it needs vectorised I/O, and send/sendto don't do 
vectorised I/O. And that vectorised I/O is a work-around for broken unicast 
senders not respecting the MTU.

I don't see why that work-around would be needed for AMT, which most likely 
does not have to deal with the same craptastic unicast servers that udp.c has 
to, and thus can dispense with all that cargo-culting from udp.c.


Also, using vlc_timer would be simpler than an ad-hoc thread here, still.

-- 
Rémi Denis-Courmont
http://www.remlab.net/