[vlc-devel] [PATCH 2/2] adaptive: Always set timestamps_offset on start

jeremy.vignelles at dev3i.fr jeremy.vignelles at dev3i.fr
Wed Sep 25 09:37:39 CEST 2019


Hi,
Thanks for your reply.

My streams rarely start at 0, since it is a "circular buffer" : files are getting removed after 3 days.
This is why there is a `- i_start` at the end.

Do you see a case where this can break?

-----Message d'origine-----
De : vlc-devel <vlc-devel-bounces at videolan.org> De la part de Francois Cartegnie
Envoyé : mardi 24 septembre 2019 18:51
À : vlc-devel at videolan.org
Objet : Re: [vlc-devel] [PATCH 2/2] adaptive: Always set timestamps_offset on start

Le 23/09/2019 à 10:43, Jérémy VIGNELLES via vlc-devel a écrit :
>      vlc_mutex_lock(&lock);
>      if( !timestamps_check_done )
>      {
> -        if( i_start < CLOCK_FREQ ) /* Starts 0 */
> -            timestamps_offset = timestamps_expected;
> +        timestamps_offset = timestamps_expected - i_start;
>          timestamps_check_done = true;
>      }
>      vlc_mutex_unlock(&lock);

This changes are the ones I pointed you to fix your own issue.

We're not going to break/desync all non zero starting streams.

-- 
Francois Cartegnie
VideoLAN - VLC Developer
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list