[vlc-devel] [PATCH] goom: remove invalid date check

Steve Lhomme robux4 at ycbcr.xyz
Wed Sep 25 11:40:32 CEST 2019


LGTM

On 2019-09-25 11:13, Thomas Guillem wrote:
> This check can't work anymore with the new output clock. i_pts is now a stream
> date and not a system one. Decoder modules are able to check frame lateness
> with decoder_GetDisplayDate() but there is no such things for filters.
> ---
>   modules/visualization/goom.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/modules/visualization/goom.c b/modules/visualization/goom.c
> index 3fa6203e1c..845f5eeebc 100644
> --- a/modules/visualization/goom.c
> +++ b/modules/visualization/goom.c
> @@ -313,9 +313,6 @@ static void *Thread( void *p_thread_data )
>           /* Speed selection */
>           if( p_thread->i_speed && (++i_count % (p_thread->i_speed+1)) ) continue;
>   
> -        /* Frame dropping if necessary */
> -        if( date_Get( &i_pts ) + GOOM_DELAY <= vlc_tick_now() ) continue;
> -
>           plane = goom_update( p_plugin_info, p_data, 0, 0.0,
>                                NULL, NULL );
>   
> -- 
> 2.20.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list