[vlc-devel] [PATCH 0/2] macosx: widen stored playback position for longer videos

Felix Paul K├╝hne fkuehne at videolan.org
Wed Sep 25 20:21:01 CEST 2019


Hi Mikhail,

Nice idea and execution.

Patch series merged!

Thanks!

Felix

> On 24. Sep 2019, at 02:02, Mikhail Gusarov <dottedmag at dottedmag.net> wrote:
> 
> Any comments?
> 
> On 19 Sep 2019, at 16:33, Mikhail Gusarov wrote:
> 
>> Existing logic of storing playback position for macOS excludes positions within
>> first/last 5%.
>> 
>> This heuristic is fine for short videos, but for a longer one, say a 6-hour one,
>> it means the position is not stored for the first/last 18 minutes, which is a
>> nuisance.
>> 
>> This change adds an upper limit for the size of excluded positions.
>> 
>> Compile-tested against master only due to UI breakage. Similar patch tested
>> against 3.0 and works fine.
>> 
>> Mikhail Gusarov (2):
>>  macosx: extract a helper to test if the position should be saved
>>  macosx: widen stored playback position for longer videos
>> 
>> .../VLCPlaybackContinuityController.m         | 33 ++++++++++++++++---
>> 1 file changed, 29 insertions(+), 4 deletions(-)
>> 
>> -- 
>> 2.22.0
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list