[vlc-devel] [PATCH 1/2] macosx: extract a helper to test if the position should be saved

[Mikhail Gusarov]

This refactoring is a prerequisite for the next commit that improves the
decision for long video files.

Signed-off-by: Mikhail Gusarov <dottedmag at dottedmag.net>
---
 modules/gui/macosx/VLCInputManager.m | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/modules/gui/macosx/VLCInputManager.m b/modules/gui/macosx/VLCInputManager.m
index 3dd9f371dc..3aa521cce8 100644
--- a/modules/gui/macosx/VLCInputManager.m
+++ b/modules/gui/macosx/VLCInputManager.m
@@ -618,6 +618,16 @@ static int InputEvent(vlc_object_t *p_this, const char *psz_var,
 
 }
 
+static const int64_t MinimumDuration = 3 * 60 * 1000;
+static const float MinimumStorePercent = 0.5;
+static const float MaximumStorePercent = 0.95;
+
+BOOL ShouldStorePlaybackPosition(float position, int64_t duration)
+{
+    return duration > MinimumDuration &&
+        position > MinimumStorePercent && position < MaximumStorePercent;
+}
+
 - (void)storePlaybackPositionForItem:(input_thread_t *)p_input_thread
 {
     if (!var_InheritBool(getIntf(), "macosx-recentitems"))
@@ -645,7 +655,7 @@ static int InputEvent(vlc_object_t *p_this, const char *psz_var,
 
     NSMutableArray *mediaList = [[defaults objectForKey:@"recentlyPlayedMediaList"] mutableCopy];
 
-    if (relativePos > .05 && relativePos < .95 && dur > 180) {
+    if (ShouldStorePlaybackPosition(relativePos, dur*1000)) {
         msg_Dbg(getIntf(), "Store current playback position of %f", relativePos);
         [mutDict setObject:[NSNumber numberWithInt:pos] forKey:url];
 
-- 
2.22.0