[vlc-devel] [PATCH] configure.ac: fail if wayland-scanner variable is empty

[Alexandre Janniaux]

Hi,

I agree that there are many possible errors. I'm not even testing
WAYLAND_PROTOCOLS. But if WAYLAND_SCANNER is empty, calls to
$(WAYLAND_SCANNER) are completely erroneous.

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Sep 26, 2019 at 10:00:20PM +0300, Rémi Denis-Courmont wrote:
> Le torstaina 26. syyskuuta 2019, 17.11.15 EEST Alexandre Janniaux a écrit :
> > ---
> >  configure.ac | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 210b4ca5371..16c688ca121 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -3378,6 +3378,8 @@ AS_IF([test "${enable_wayland}" != "no"], [
> >    ])
> >    PKG_CHECK_MODULES([WAYLAND_SCANNER], [wayland-scanner >= 1.15], [
> >      WAYLAND_SCANNER="$(${PKG_CONFIG} wayland-scanner --variable
> > wayland_scanner)" +    AS_IF([ test "x$WAYLAND_SCANNER" = "x" ], [
> > +        wl_err"$wl_err couldn't find wayland-scanner"])
> >    ], [
> >      wl_err="$wl_err ${WAYLAND_SCANNER_PKG_ERRORS}."
> >    ])
>
> There are infinitely many hypothetical errors that the underlying SDK could
> have. I don't think it is the configure script's job to work around them.
>
> If the wayland-scanner package exists, it cannot not define the variable.
>
> --
> Реми Дёни-Курмон
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel