[vlc-devel] [PATCH] qt: player_controller: use UpdateVouts to update vouts

[Alexandre Janniaux]

Actually, it might raise issue in the current form, as we won't
have other vout_list_changed event.

Please discard this patch, thank you.

Regards,
--
Alexandre Janniaux
Videolabs

On Fri, Sep 27, 2019 at 12:05:06PM +0200, Alexandre Janniaux wrote:
> player_controller is holding vouts, using UpdateVouts ensure they are
> correctly released if we don't use them anymore. This is only a sanity
> fix as it would raise issue only with embedded video.
> ---
>  modules/gui/qt/components/player_controller.cpp | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/modules/gui/qt/components/player_controller.cpp b/modules/gui/qt/components/player_controller.cpp
> index b4432ccdaa1..e791cd8515b 100644
> --- a/modules/gui/qt/components/player_controller.cpp
> +++ b/modules/gui/qt/components/player_controller.cpp
> @@ -317,10 +317,8 @@ static void on_player_state_changed(vlc_player_t *, enum vlc_player_state state,
>              emit q->ABLoopStateChanged(PlayerController::ABLOOP_STATE_NONE);
>              emit q->ABLoopAChanged(VLC_TICK_INVALID);
>              emit q->ABLoopBChanged(VLC_TICK_INVALID);
> -            that->m_hasVideo = false;
> -            emit q->hasVideoOutputChanged( false );
>
> -            emit q->voutListChanged( NULL, 0 );
> +            that->UpdateVouts(NULL, 0);
>
>              /* Reset all InfoPanels but stats */
>              that->m_artUrl = "";
> --
> 2.23.0
>