[vlc-devel] [3.0 PATCH 0/2] macosx: widen stored playback position for longer videos

Felix Paul K├╝hne fkuehne at videolan.org
Fri Sep 27 20:59:51 CEST 2019


Hello Mikhail,

Thanks for your second patch series! I just merged it with one silent fix (that I also already did for the master branch). You configured the MinimumStorePercent to 0.5 whereas it should be 0.05.

Nice work!

Best regards,

Felix

> On 25. Sep 2019, at 21:40, Mikhail Gusarov <dottedmag at dottedmag.net> wrote:
> 
> Existing logic of storing playback position for macOS excludes positions within
> first/last 5%.
> 
> This heuristic is fine for short videos, but for a longer one, say a 6-hour one,
> it means the position is not stored for the first/last 18 minutes, which is a
> nuisance.
> 
> This change adds an upper limit for the size of excluded positions.
> 
> This is a backport from master branch, commits
> 08f4413550de4912f6b5f3f67976898944e254ca and
> be727c15a67e632adff3c33af8a79af3df2dfade. 
> 
> Mikhail Gusarov (2):
>  macosx: extract a helper to test if the position should be saved
>  macosx: widen stored playback position for longer videos
> 
> modules/gui/macosx/VLCInputManager.m | 28 +++++++++++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
> 
> -- 
> 2.22.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list