[vlc-devel] [PATCH v2] qt: Size extra-metadata columns to contents

[Pierre Lamot]

On samedi 28 septembre 2019 06:22:56 CEST FeRD wrote:
> Ugh, apologies. The first patch got mangled in transit. Resending as an
> attachment, best I can do for the moment.
> 
> On Fri, Sep 27, 2019 at 10:23 PM FeRD (Frank Dana) <ferdnyc at gmail.com>
> wrote:
> 
> > Set the SectionResizeMode of column headers (and row headers) of the
> > extra-metadata table to QHeaderView::ResizeToContents, to correctly
> > display the table data.
> >
> > Without these properties set, the left (key) column is sized far too
> > narrow and cuts off most of the text. Many rows are unnecessarily
> > tall, with their right (value) column's contents vertically centered.
> >
> > Signed-off-by: FeRD (Frank Dana) <ferdnyc at gmail.com>
> >
> 

Hi,

`extraMeta->verticalHeader()->resizeSections( QHeaderView::ResizeToContents );` was called  in the "ExtraMetaPanel::update" method, I think your patch makes this call unnecessary. 

otherwise, it looks good to me

--
Pierre Lamot