[vlc-devel] [PATCH] contrib: unexport env variables when cross-compiling

[Marvin Scholz]

On 30 Sep 2019, at 21:42, Rémi Denis-Courmont wrote:

> Le maanantaina 30. syyskuuta 2019, 18.43.46 EEST Marvin Scholz a 
> écrit :
>> Meson always interprets these env variables for the build compiler,
>> even when cross-compiling, therefore we need to unset them,
>
> No. You need to set them to the correct values.
>
> Sorry but this patch is a gross hack and is liable to break especially 
> native
> (tools) compilation.

Hi, thanks for the review,

I do not understand how this would break native tools compilation
though.

Just like we don't set native tools variables for autotools,
with that patch we do not do it for meson either and it will just
autodetect just like configure would do, no?

The unset variables are not lost, they get inserted into the meson
cross-file and are used as expected there.

I do not understand the issue and do not understand to what correct 
values
I should set them, can you please elaborate on that?

>
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel