[vlc-devel] [PATCH 1/3] sdp: remove no longer used sdp_AddAttribute()

[Rémi Denis-Courmont]

---
 include/vlc_sout.h      |  2 --
 src/libvlccore.sym      |  1 -
 src/missing.c           |  6 ------
 src/stream_output/sdp.c | 23 -----------------------
 4 files changed, 32 deletions(-)

diff --git a/include/vlc_sout.h b/include/vlc_sout.h
index 4534d9f5d5..e5f7eebf0e 100644
--- a/include/vlc_sout.h
+++ b/include/vlc_sout.h
@@ -287,8 +287,6 @@ VLC_API void sdp_AddMedia(struct vlc_memstream *, const char *type,
                           bool bw_indep, unsigned bw, const char *ptname,
                           unsigned clockrate, unsigned channels,
                           const char *fmtp);
-VLC_API void sdp_AddAttribute(struct vlc_memstream *, const char *name,
-                              const char *fmt, ...) VLC_FORMAT(3, 4);
 
 /** @} */
 
diff --git a/src/libvlccore.sym b/src/libvlccore.sym
index 9effd1246e..2cf98e5091 100644
--- a/src/libvlccore.sym
+++ b/src/libvlccore.sym
@@ -322,7 +322,6 @@ picture_pool_Wait
 picture_Reset
 picture_Setup
 plane_CopyPixels
-sdp_AddAttribute
 sdp_AddMedia
 secstotimestr
 sout_AccessOutControl
diff --git a/src/missing.c b/src/missing.c
index 982df95d36..2ebd9ab8be 100644
--- a/src/missing.c
+++ b/src/missing.c
@@ -54,12 +54,6 @@ void sdp_AddMedia (struct vlc_memstream *sdp, const char *type, const char *prot
     assert (sdp == NULL);
 }
 
-void sdp_AddAttribute (struct vlc_memstream *sdp, const char *name, const char *fmt, ...)
-{
-    VLC_UNUSED (sdp); VLC_UNUSED (name); VLC_UNUSED (fmt);
-    assert (sdp == NULL);
-}
-
 noreturn int sout_AccessOutControl(sout_access_out_t *out, int query, ...)
 {
     VLC_UNUSED (out); VLC_UNUSED (query);
diff --git a/src/stream_output/sdp.c b/src/stream_output/sdp.c
index dc13ec0601..65aefa4cb4 100644
--- a/src/stream_output/sdp.c
+++ b/src/stream_output/sdp.c
@@ -90,29 +90,6 @@ static bool IsSDPString (const char *str)
     return true;
 }
 
-static void vsdp_AddAttribute(struct vlc_memstream *restrict stream,
-                              const char *name, const char *fmt, va_list ap)
-{
-    if (fmt == NULL)
-    {
-        vlc_memstream_printf(stream, "a=%s\r\n", name);
-        return;
-    }
-    vlc_memstream_printf(stream, "a=%s:", name);
-    vlc_memstream_vprintf(stream, fmt, ap);
-    vlc_memstream_puts(stream, "\r\n");
-}
-
-void sdp_AddAttribute(struct vlc_memstream *restrict stream, const char *name,
-                      const char *fmt, ...)
-{
-    va_list ap;
-
-    va_start(ap, fmt);
-    vsdp_AddAttribute(stream, name, fmt, ap);
-    va_end(ap);
-}
-
 void sdp_AddMedia(struct vlc_memstream *restrict stream,
                   const char *type, const char *proto, int dport,
                   unsigned pt, bool bw_indep, unsigned bw,
-- 
2.26.0