[vlc-devel] [PATCH 1/2] sdp: drop URL and email

RĂ©mi Denis-Courmont remi at remlab.net
Wed Apr 1 21:34:51 CEST 2020


This is about as useless as the phone number which was dropped in 3.0.
At least, the VLC SDP parser ignores those fields.
---
 src/stream_output/sdp.c | 24 +-----------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

diff --git a/src/stream_output/sdp.c b/src/stream_output/sdp.c
index 0c9ca23e42..304433beaf 100644
--- a/src/stream_output/sdp.c
+++ b/src/stream_output/sdp.c
@@ -148,29 +148,7 @@ int vlc_sdp_Start(struct vlc_memstream *restrict stream,
     else
         vlc_memstream_printf(stream, "i=%s\r\n", "N/A");
 
-    strcpy(subvar, "url");
-    str = var_GetNonEmptyString(obj, varname);
-    if (str != NULL)
-    {
-        if (!IsSDPString(str))
-            goto error;
-
-        vlc_memstream_printf(stream, "u=%s\r\n", str);
-        free(str);
-    }
-
-    strcpy(subvar, "email");
-    str = var_GetNonEmptyString(obj, varname);
-    if (str != NULL)
-    {
-        if (!IsSDPString(str))
-            goto error;
-
-        vlc_memstream_printf(stream, "e=%s\r\n", str);
-        free(str);
-    }
-
-    // no phone (useless)
+    // no URL, email, no phone (useless)
 
     vlc_memstream_printf(stream, "c=%s\r\n", connection);
     // bandwidth not specified
-- 
2.26.0



More information about the vlc-devel mailing list