[vlc-devel] [PATCH 05/12] vlc_player: store title angles

[Thomas Guillem]

On Thu, Apr 2, 2020, at 20:40, Francois Cartegnie wrote:
> ---
>  include/vlc_player.h | 2 ++
>  src/player/title.c   | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/include/vlc_player.h b/include/vlc_player.h
> index 763aae564d..6643f2ebed 100644
> --- a/include/vlc_player.h
> +++ b/include/vlc_player.h
> @@ -963,6 +963,8 @@ struct vlc_player_title
>      unsigned flags;
>      /** Number of chapters, can be 0 */
>      size_t chapter_count;
> +    /** Number of additional viewing angles, usually 0 */
> +    unsigned char additional_angles;

If it's a (very small) number, it should be an uint8_t instead of a uchar, no ?

>      /** Array of chapters, can be NULL */
>      const struct vlc_player_chapter *chapters;
>  };
> diff --git a/src/player/title.c b/src/player/title.c
> index 5f6942ca68..ea0c728be5 100644
> --- a/src/player/title.c
> +++ b/src/player/title.c
> @@ -125,6 +125,7 @@ vlc_player_title_list_Create(input_title_t *const 
> *array, size_t count,
>          const size_t seekpoint_count = input_title->i_seekpoint > 0 ?
>                                         input_title->i_seekpoint : 0;
>          title->chapter_count = seekpoint_count;
> +        title->additional_angles = input_title->i_additional_angles;
>  
>          struct vlc_player_chapter *chapters = title->chapter_count == 
> 0 ? NULL :
>              vlc_alloc(title->chapter_count, sizeof(*chapters));
> -- 
> 2.25.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel