[vlc-devel] [PATCH 01/12] vlc_input: add title angles

Rémi Denis-Courmont remi at remlab.net
Fri Apr 3 09:15:20 CEST 2020


Le perjantaina 3. huhtikuuta 2020, 9.58.16 EEST Thomas Guillem a écrit :
> On Fri, Apr 3, 2020, at 08:52, Rémi Denis-Courmont wrote:
> > Le torstaina 2. huhtikuuta 2020, 21.40.09 EEST Francois Cartegnie a écrit 
:
> > > ---
> > > 
> > >  include/vlc_input.h | 3 +++
> > >  1 file changed, 3 insertions(+)
> > 
> > I'm not convinved that angles should be exposed separately. AFAICT, it's
> > not technically different from multiple exclusive video tracks. The fact
> > that they're called angles is just semantics.
> > 
> > As far as this patchset goes, it only concerns DVDs (which don't have
> > multiple video tracks currently), and VLC is pretty much out of free
> > hotkeys at this point.
> 
> The hotkey issue can be addressed in the control module, it can switch
> angles before switching tracks for example.

That's even worse than leaving an unassigned pair of hotkeys. With that 
approach, all VLC UIs, and any LibVLC app that want to do the same, has to 
implement the same bespoke track handling to cover tracks and angles.

-- 
Rémi Denis-Courmont
http://www.remlab.net/





More information about the vlc-devel mailing list