[vlc-devel] [PATCH] contrib: libarchive: fix the missing statvfs patch

Steve Lhomme robux4 at ycbcr.xyz
Fri Apr 3 10:27:58 CEST 2020


On 2020-04-03 10:18, Rémi Denis-Courmont wrote:
> Le perjantaina 3. huhtikuuta 2020, 10.39.20 EEST Steve Lhomme a écrit :
>> The code assumed that statfs had a f_flag field in some places (but not
>> others) but it's in fact it's f_flags.
>>
>> Android compiles fine with this patch (and all other targets in Gitlab CI)
> 
> I don't really see the point either way. VLC does not use libarchive to access
> system-mounted filesystems, so it should never need to use POSIX statvfs() nor
> Linux statfs().

The patch is there so that libarchive compiles (on Android). It doesn't 
matter if it works or not if it doesn't compile.


More information about the vlc-devel mailing list