[vlc-devel] [3.0 PATCH 1/2] configure: Make the new value of _WIN32_WINNT available to configure tests

Steve Lhomme robux4 at ycbcr.xyz
Fri Apr 3 10:57:12 CEST 2020


On 2020-04-02 22:11, Martin Storsjö wrote:
> On Thu, 2 Apr 2020, Steve Lhomme wrote:
> 
>> LGTM
>>
>> It's slightly different from the one I submitted earlier, by testing 
>> the _WIN32_WINNT value:
>> [3.0 PATCH v2 18/20] configure: Make the new value of _WIN32_WINNT 
>> available to configure tests
> 
> Yep, I tested yours as well, but I think I prefer this form, to avoid 
> forcing _WIN32_WINNT to a lower-than-default version which easily could 
> give inconsistent results as well.

For 3.0 I guess that's good as it's a hard limit we can't go below.

For 4.0 it's debatable as it might be possible to build for Vista and 
things mostly work. If we decide we don't want that, it should be done 
in 4.0 first and then backported to 3.0.


More information about the vlc-devel mailing list