[vlc-devel] [PATCH 01/12] vlc_input: add title angles

Alexandre Janniaux ajanni at videolabs.io
Sat Apr 4 18:59:27 CEST 2020


Hi,

Can you add more context in the commit message and more info
in the patchset about those values?

In particular, it's not really clear what values here should
be used, or which unit should be used.

I guess that it provides ┬źdifferent scene┬╗ that could be
accessed/demuxed specifically (given set/get_angle) but
why it would be a uint8_t is a little blurred and seems
dependent on the format initially used. Also it might not
be clear for future reader of the patchset once merged.

Maybe there's no point in using a uint8_t and you can switch
to an unsigned integer instead? It's not that important to me
though so not really a blocking issue compared to more info
in the patchset.

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Apr 02, 2020 at 08:40:09PM +0200, Francois Cartegnie wrote:
> ---
>  include/vlc_input.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/vlc_input.h b/include/vlc_input.h
> index 7d24f11830..e61f44b308 100644
> --- a/include/vlc_input.h
> +++ b/include/vlc_input.h
> @@ -101,6 +101,7 @@ typedef struct input_title_t
>      /* Title seekpoint */
>      int         i_seekpoint;
>      seekpoint_t **seekpoint;
> +    uint8_t     i_additional_angles; /* controllable viewing angles */
>  } input_title_t;
>
>  static inline input_title_t *vlc_input_title_New(void)
> @@ -112,6 +113,7 @@ static inline input_title_t *vlc_input_title_New(void)
>      t->psz_name = NULL;
>      t->i_flags = 0;
>      t->i_length = 0;
> +    t->i_additional_angles = 0;
>      t->i_seekpoint = 0;
>      t->seekpoint = NULL;
>
> @@ -139,6 +141,7 @@ static inline input_title_t *vlc_input_title_Duplicate( const input_title_t *t )
>      if( t->psz_name ) dup->psz_name = strdup( t->psz_name );
>      dup->i_flags     = t->i_flags;
>      dup->i_length    = t->i_length;
> +    dup->i_additional_angles = t->i_additional_angles;
>      if( t->i_seekpoint > 0 )
>      {
>          dup->seekpoint = (seekpoint_t**)vlc_alloc( t->i_seekpoint, sizeof(seekpoint_t*) );
> --
> 2.25.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list