[vlc-devel] [vlc-commits] l10n: enabling Khmer

[Michał]

Thanks for the info!

Indeed, if Khmer isn't working, it's better to remove it for now. I
will exclude it from the generating script till we have a fix here.
Thanks to the commit, it's clear now which languages in NSIS are
currently supported. This will be an indicator when accepting new
translations from Tx.
All other files from my repo were also committed today, so there is
nothing left for now and the 3.0.9 can released.
_______________________________________________________________

webpage update:
I also update the webpage (videolan.org) with new translations and
created a better language selector with native names like the same
selector as in the main app. Today I pushed a small correction for it
(auto-select the lang name), maybe someone can merge this MR:
https://code.videolan.org/VideoLAN.org/websites/-/merge_requests/23

Although the new po files were added to the webpage-git these files
weren't compiled yet, so the changes aren't online at the moment. New
added languages are still missing and creating a 404 page, like:
am-ET, br, eu, lb, my-MM, ne-NP, nn, sc, ug, wa

Could someone compile the new translations files that are listed in
"Makefile.inc"?
That would be an important point to solve before the new version
release, 404 pages are not nice.
_______________________________________________________________

Future steps:
We should put this nice selector on a more prominent place on the
page. I played around with the bootstrap layout of the page and
implement it as one point in header's nav bar or put it as a new menu
point in one of the dropdowns but the results aren't final yet. The
current position of the selector in the footer is too hidden IMO. I
can show you some examples when this is presentable. But this is on a
low priority at the moment, looks good for now, any suggestions on
this are welcome.

And there is also an idea to update the credits on this page
(https://www.videolan.org/developers/i18n/) with the current ones from
Tx and maybe fix the stats generating. Tx have a possibility to
generate a detail translation status so this could be used as a
source. Any information how the old script was working would be
helpful. Or how the structure of the missing file "vlc-stats.ref"
should looks like. This is also on low prio.


merci beaucoup,
MT



2020-04-05 15:16 GMT+02:00, David Fuhrmann <david.fuhrmann at gmail.com>:
> Hi,
>
> Thanks for noticing, sure revert is fine for me for now as the build is
> broken.
> I added Michal to the mail, not sure if he is on this mailing list here.
>
> BR. David
>
>> Am 05.04.2020 um 14:55 schrieb Konstantin Pavlov <thresh at videolan.org>:
>>
>> Hello,
>>
>> On Sat, Apr 04, 2020 at 04:58:54PM +0000, Michał Trzebiatowski wrote:
>>> vlc/vlc-3.0 | branch: master | Michał Trzebiatowski <michtrz at gmail.com> |
>>> Fri Mar 27 21:53:30 2020 +0100|
>>> [242441abaf5619f0a23b677952398f794a6ddeac] | committer: David Fuhrmann
>>>
>>> l10n: enabling Khmer
>>>
>>>> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=242441abaf5619f0a23b677952398f794a6ddeac
>>> ---
>>>
>>> extras/package/win32/NSIS/vlc.win32.nsi.in | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/extras/package/win32/NSIS/vlc.win32.nsi.in
>>> b/extras/package/win32/NSIS/vlc.win32.nsi.in
>>> index b1397c6956..05273207ca 100644
>>> --- a/extras/package/win32/NSIS/vlc.win32.nsi.in
>>> +++ b/extras/package/win32/NSIS/vlc.win32.nsi.in
>>> @@ -231,6 +231,8 @@ RequestExecutionLevel admin
>>>   !insertmacro LANGFILE_INCLUDE_WITHDEFAULT "AsturianExtra.nsh"
>>> ${VLC_LANGFILE_FALLBACK}
>>>   !insertmacro MUI_LANGUAGE "Corsican"
>>>   !insertmacro LANGFILE_INCLUDE_WITHDEFAULT "CorsicanExtra.nsh"
>>> ${VLC_LANGFILE_FALLBACK}
>>> +  !insertmacro MUI_LANGUAGE "Khmer"
>>> +  !insertmacro LANGFILE_INCLUDE_WITHDEFAULT "KhmerExtra.nsh"
>>> ${VLC_LANGFILE_FALLBACK}
>>
>> I think this should be reverted, since Khmer is not shipped by default in
>> NSIS releases, which causes installer builds to fail:
>>
>> Error: Can't open language file - "/usr/share/nsis\Contrib\Language
>> files\Khmer.nlf"!
>> Error in macro MUI_LANGUAGEEX on macroline 13
>> Error in macro MUI_LANGUAGE on macroline 4
>> Error in script "./vlc-3.0.9/vlc.win32.nsi" on line 234 -- aborting
>> creation process
>>
>>
>> I have opened a pull request to enable it and some other languages, but
>> even if it is merged, we will need to wait until it propagates to at
>> least
>> debian unstable to use it on our builders.
>>
>> The PR is at https://github.com/kichik/nsis/pull/11
>> <https://github.com/kichik/nsis/pull/11>
>>
>> --
>> VideoLAN, Vice President
>> www.videolan.org <http://www.videolan.org/>
>> +7 926 165 45 31
>> @cryothresh
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>> <https://mailman.videolan.org/listinfo/vlc-devel>
>