[vlc-devel] [PATCH] thread: change posix thread priorities to 0

[Rémi Denis-Courmont]

Le maanantaina 6. huhtikuuta 2020, 11.13.29 EEST Steve Lhomme a écrit :
> On 2020-04-06 10:02, Rémi Denis-Courmont wrote:
> > Le lauantaina 4. huhtikuuta 2020, 4.13.45 EEST Marvin Scholz a écrit :
> >> Makes it clearer that those have no effect anymore now.
> > 
> > IMO, we should remove the priority parameter as François implied.
> > 
> > If somebody really has a demonstrated use of priorities, they can use
> > their
> > OS-specific call or vlc_set_priority().
> 
> That means calling vlc_set_priority() in the 101 places vlc_clone() is
> called.

No, it does not. The number of threads that actually follow coding principles 
to benefit for prioritization can be counted with the fingers on one hand, and 
even some of them are on platforms where we never implemented priorities (e.g. 
macOS audio plugins).

> Unless it's demontrasted that it doesn't work I prefer the conservative
> approach of keeping things as they are.

That's called cargo cult programming.

> Unless you plan to fix it if it
> actually breaks/damages things.

Of course not. I'm not going to fix something that probably never worked and 
has definitely not been working for over a decade.

-- 
Rémi Denis-Courmont
Tapiolan uusi kaupunki, Uudenmaan tasavalta