[vlc-devel] [VLC-3.0 2/2] aom: don't pass the private structure pointer, just the index

Hugo Beauzée-Luyssen hugo at beauzee.fr
Mon Apr 6 13:41:44 CEST 2020


On Mon, Apr 6, 2020, at 12:16 PM, Rémi Denis-Courmont wrote:
> Le maanantaina 6. huhtikuuta 2020, 13.05.46 EEST Hugo Beauzée-Luyssen a écrit 
> :
> > From: Steve Lhomme <robux4 at ycbcr.xyz>
> > 
> > We can never get a NULL pointer from libaom this way. The PTS may be wrong
> > but it won't crash.
> 
> AFAIK storing an arbitrary integer in a pointer is not portable. Been there 
> done that. It's (only) the other way around that is portable.
> 

Hi,

The patch is already pushed on master and backported on 3.0, the question was more about revert + re-backporting in 2 separated patches, or if a squashed commit, effectively reverting the whitespace changes, was preferable.

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr


More information about the vlc-devel mailing list