[vlc-devel] [PATCH] nvdec: fix segfault in nvdec_gl

[Steve Lhomme]

Ok then please say so in the commit message. Thanks.

On 2020-04-07 8:11, Quentin Chateau wrote:
> Hi,
> 
> interop->priv is set only at the end of the Open function. Which means
> it will be NULL in an earlier call to Close.
> On Apr 7, 2020, at 07:48, Steve Lhomme <robux4 at ycbcr.xyz 
> <mailto:robux4 at ycbcr.xyz>> wrote:
> 
>     Hi,
> 
>     I still think the commit is wrong, unless you explain how you get the
>     segfault.
>     The code is OK.
> 
>     On 2020-04-06 17:43, quentin.chateau at deepskycorp.com wrote:
> 
>         From: Quentin Chateau <quentin.chateau at deepskycorp.com>
> 
>         ---
>         modules/hw/nvdec/nvdec_gl.c | 2 +-
>         1 file changed, 1 insertion(+), 1 deletion(-)
> 
>         diff --git a/modules/hw/nvdec/nvdec_gl.c
>         b/modules/hw/nvdec/nvdec_gl.c
>         index 137e730028..9d994b40cd 100644
>         --- a/modules/hw/nvdec/nvdec_gl.c
>         +++ b/modules/hw/nvdec/nvdec_gl.c
>         @@ -212,7 +212,7 @@ static int Open(vlc_object_t *obj)
>         int ret = opengl_interop_init(interop, GL_TEXTURE_2D,
>         render_chroma, interop->fmt.space <http://fmt.space>);
>         if (ret != VLC_SUCCESS)
>         {
>         - Close(obj);
>         + vlc_decoder_device_Release(device);
>         return ret;
>         }
> 
>         -- 
>         2.17.1
> 
>         ------------------------------------------------------------------------
> 
>         vlc-devel mailing list
>         To unsubscribe or modify your subscription options:
>         https://mailman.videolan.org/listinfo/vlc-devel
> 
>     ------------------------------------------------------------------------
> 
>     vlc-devel mailing list
>     To unsubscribe or modify your subscription options:
>     https://mailman.videolan.org/listinfo/vlc-devel
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>