[vlc-devel] [PATCH] contrib: libssp: build libssp on Win32 so we can patch it to use bcrypt

[Steve Lhomme]

On 2020-04-07 15:27, Martin Storsjö wrote:
> On Tue, 7 Apr 2020, Steve Lhomme wrote:
> 
>> diff --git a/contrib/src/libssp/SHA512SUMS 
>> b/contrib/src/libssp/SHA512SUMS
>> new file mode 100644
>> index 00000000000..f750660d9cb
>> --- /dev/null
>> +++ b/contrib/src/libssp/SHA512SUMS
>> @@ -0,0 +1 @@
>> +40a2ee4fb42fc6474a0fbde208bfff310e160fcb1b015c09f50e7bb7f6039e5b0f81048fc09b239a1e2f03a67b7d8bfe37e64b1683105d2c1ff0af662a65262e  
>> libssp-9_2_0.tar.gz
>> diff --git a/contrib/src/libssp/rules.mak b/contrib/src/libssp/rules.mak
>> new file mode 100644
>> index 00000000000..42fed0c714b
>> --- /dev/null
>> +++ b/contrib/src/libssp/rules.mak
>> @@ -0,0 +1,28 @@
>> +# libssp
>> +LIBSSP_VERSION := 9_2_0
>> +LIBSSP_SVNURL := 
>> svn://gcc.gnu.org/svn/gcc/tags/gcc_$(LIBSSP_VERSION)_release/libssp
> 
> Oh, does this url still work now? I had to change it in llvm-mingw a 
> while back, 
> https://github.com/mstorsjo/llvm-mingw/commit/ad3d710c9a0fe40193b01c4a87fb0cde7fdf9718#diff-61ff93e7b0a019a6b2791677ea7c6770, 
> as the old SVN url didn't seem to work at the time. But maybe it only 
> was temporary - keeping the old SVN intact at the old url would indeed 
> be the most sensible thing to do.

I got the idea of this looking at your LLVM-mingw script. Then "svn ls" 
gave me the available tags.

>> +.libssp: libssp
>> +    $(RECONF)
>> +    cd $< && $(HOSTVARS) ./configure $(HOSTCONF)
>> +    cd $< && $(MAKE) install
> 
> Does this work with clang/llvm-mingw as well? When I tested building 
> libssp using the normal automake build system (in the subdir in a full 
> gcc checkout, iirc) its configure script failed due to wanting to test 
> some obscure flags that clang didn't implement at the time - that's why 
> I've bundled a small handwritten makefile instead in llvm-mingw. Or 
> maybe it was just due to it not working standalone in a subdir?

Yes most of it is due to assuming it's ran in the gcc tree. I think all 
the things you disabled should be detected as missing by the configure 
script, but I might be wrong. At least I used LLVM-mingw to build & test 
it, so I suppose it should work in your script too.