[vlc-devel] [PATCH] contrib: libssp: build libssp on Win32 so we can patch it to use bcrypt

[Steve Lhomme]

On 2020-04-07 16:06, Rémi Denis-Courmont wrote:
> Le tiistaina 7. huhtikuuta 2020, 16.11.37 EEST Steve Lhomme a écrit :
>> diff --git a/contrib/src/libssp/rules.mak b/contrib/src/libssp/rules.mak
>> new file mode 100644
>> index 00000000000..42fed0c714b
>> --- /dev/null
>> +++ b/contrib/src/libssp/rules.mak
>> @@ -0,0 +1,28 @@
>> +# libssp
>> +LIBSSP_VERSION := 9_2_0
>> +LIBSSP_SVNURL :=
>> svn://gcc.gnu.org/svn/gcc/tags/gcc_$(LIBSSP_VERSION)_release/libssp +
>> +ifdef HAVE_WIN32
>> +PKGS += libssp
>> +endif
> 
> This really just a more general and abstract respin of Martin's question, but
> I think overriding a toolchain library is a very bad idea.
> 
> Conversely, *if* it's really necessary, then it should be disabled by default.

The move to bcrypt is needed for winstore/uwp/uap builds. For win32 it 
really depends if we want to keep a chance to support XP or not (I vote 
no). We may also decide that the one from the toolchain (which is not 
officially part of LLVM ? A package detection would be nice) is good enough.

I'll submit the patch to move away from wincrypt, so hopefully we won't 
even need to patch in the future.

As for "it should be disabled by default" do you mean bcrypt in libssp 
or libssp in VLC ?

>> +
>> +$(TARBALLS)/libssp-$(LIBSSP_VERSION).tar.gz:
>> +	rm -rf libssp-$(LIBSSP_VERSION) libssp
>> +	$(SVN) checkout -q $(LIBSSP_SVNURL)
>> +	rm -rf libssp/.svn
>> +	mv libssp libssp-$(LIBSSP_VERSION)
>> +	tar czf $@ libssp-$(LIBSSP_VERSION)
>> +
>> +.sum-libssp: libssp-$(LIBSSP_VERSION).tar.gz
>> +
>> +libssp: libssp-$(LIBSSP_VERSION).tar.gz .sum-libssp
>> +	$(UNPACK)
>> +	$(APPLY)
>> $(SRC)/libssp/0001-favor-bcrypt-over-wincrypt-for-the-random-generator-.pat
>> ch +	$(APPLY)
>> $(SRC)/libssp/0002-allow-building-outside-of-the-gcc-tree.patch +	$(MOVE)
>> +
>> +.libssp: libssp
>> +	$(RECONF)
>> +	cd $< && $(HOSTVARS) ./configure $(HOSTCONF)
>> +	cd $< && $(MAKE) install
>> +	touch $@
> 
> 
> -- 
> Rémi Denis-Courmont
> Hagalund ny stad, Nylands republik
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>