[vlc-devel] [PATCH 2/2] contrib: harfbuzz: Avoid harfbuzz using 'icu-config' for finding ICU

Martin Storsjö martin at martin.st
Wed Apr 8 13:51:13 CEST 2020


When cross compiling, we shouldn't let packages' build systems
accidentally pick up libraries from the surrounding native environment.
Normally this is accomplished by setting PKG_CONFIG_LIBDIR.
Harfbuzz's configure script tries looking for ICU using the tool
icu-config, if it isn't found with pkg-config.

Set ICU_CONFIG to false, to avoid configure using and picking it up.
---
 contrib/src/harfbuzz/rules.mak | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/src/harfbuzz/rules.mak b/contrib/src/harfbuzz/rules.mak
index 04e46c6ebd..2d4352860c 100644
--- a/contrib/src/harfbuzz/rules.mak
+++ b/contrib/src/harfbuzz/rules.mak
@@ -29,6 +29,6 @@ endif
 
 .harfbuzz: harfbuzz
 	$(RECONF)
-	cd $< && $(HOSTVARS_PIC) ./configure $(HOSTCONF) $(HARFBUZZ_CONF)
+	cd $< && $(HOSTVARS_PIC) ./configure $(HOSTCONF) $(HARFBUZZ_CONF) ICU_CONFIG=false
 	cd $< && $(MAKE) install
 	touch $@
-- 
2.17.1



More information about the vlc-devel mailing list