[vlc-devel] [PATCH v2 10/15] rand: simplify

Rémi Denis-Courmont remi at remlab.net
Wed Apr 8 17:02:16 CEST 2020

Le keskiviikkona 8. huhtikuuta 2020, 13.49.09 EEST Alexandre Janniaux a écrit 
> Hi,
> On Wed, Apr 08, 2020 at 01:30:44PM +0300, Rémi Denis-Courmont wrote:
> > That __MIN kludge is not namespace-safe. No thanks. And the whole concept
> > is intrinsically broken as a correct min macro would *really* need to be
> > both expansion-safe (__MIN is not) and constant-safe.
> TBH, it feels like excessive requirement on a location

I disagree and that's how it always starts, and how it ends badly when the 
code is revectored.

> that
> doesn't require it. Even if __MIN is redefined, it would
> warn and in any case it's really likely to be the same
> minimum operation.

TBH, I care more about the spec and actual implementations than your opinions/
wishes here.

Rémi Denis-Courmont
Ville neuve de Tapiola, République d´Uusimaa

More information about the vlc-devel mailing list