[vlc-devel] [PATCH v3 02/14] src: add cleaner md5 API

[Rémi Denis-Courmont]

Le keskiviikkona 8. huhtikuuta 2020, 17.54.06 EEST Francois Cartegnie a écrit 
:
> Le 08/04/2020 à 16:10, Marvin Scholz a écrit :
> > +void vlc_hash_md5_FinishHex(vlc_hash_md5_t *ctx, char *output, size_t
> > size) +{
> > +    assert(size >= VLC_HASH_MD5_DIGEST_SIZE);
> > +    VLC_UNUSED(size);
> > +
> > +    md5_final(&ctx->priv);
> > +    vlc_hex_encode_binary(ctx->priv.buf, VLC_HASH_MD5_DIGEST_SIZE,
> > output); +    vlc_hash_md5_Init(ctx);
> 
> That's still creating an API for something not related to md5.

It should probably be a separate patch, but pragmatically, it is needed in the 
patchset, even if it's separate.

-- 
Rémi Denis-Courmont
Hagalund ny stad, Nylands republik