[vlc-devel] [PATCH] Convert int to bool in Audio Bargraph

[Thomas Guillem]

Hello,

Your patch is still wrong: it is a patch of your 1st patch. You need to squash it, cf. git rebase -i origin and fixup/squash.

On Wed, Apr 8, 2020, at 15:07, Vedanta Nayak wrote:
> Apologies. I attached the old patch file along with the new one. 
> I have reattached the new patch only this time. 
> By default value, I am assuming you mean the "1" which was changed to false in
> my code. I have changed it to true.
> 
> ---
>  modules/audio_filter/audiobargraph_a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/audio_filter/audiobargraph_a.c 
> b/modules/audio_filter/audiobargraph_a.c
> index d5bdad5be0..4c7215153d 100644
> --- a/modules/audio_filter/audiobargraph_a.c
> +++ b/modules/audio_filter/audiobargraph_a.c
> @@ -74,9 +74,9 @@ vlc_module_begin ()
>  
>      add_obsolete_string( CFG_PREFIX "address" )
>      add_obsolete_integer( CFG_PREFIX "port" )
> -    add_bool( CFG_PREFIX "bargraph", false, BARGRAPH_TEXT, 
> BARGRAPH_LONGTEXT, false ) 
> +    add_bool( CFG_PREFIX "bargraph", true, BARGRAPH_TEXT, 
> BARGRAPH_LONGTEXT, false ) 
>      add_integer( CFG_PREFIX "bargraph_repetition", 4, 
> BARGRAPH_REPETITION_TEXT, BARGRAPH_REPETITION_LONGTEXT, false )
> -    add_bool( CFG_PREFIX "silence", false, SILENCE_TEXT, 
> SILENCE_LONGTEXT, false )
> +    add_bool( CFG_PREFIX "silence", true, SILENCE_TEXT, 
> SILENCE_LONGTEXT, false )
>      add_integer( CFG_PREFIX "time_window", 5000, TIME_WINDOW_TEXT, 
> TIME_WINDOW_LONGTEXT, false )
>      add_float( CFG_PREFIX "alarm_threshold", 0.02, 
> ALARM_THRESHOLD_TEXT, ALARM_THRESHOLD_LONGTEXT, false )
>      add_integer( CFG_PREFIX "repetition_time", 2000, 
> REPETITION_TIME_TEXT, REPETITION_TIME_LONGTEXT, false )
> -- 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel