[vlc-devel] [PATCH 1/3] vulkan: force swapchain resize on display size change

[Alexandre Janniaux]

Hi,

It seems that this commit is wrong given the current
libplacebo version required, so it would need #ifdef or
upgrading the libplacebo version.

As the Wayland platform depends upon this too, I didn't
apply both, so they will be deferred until I fixed this.

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, Apr 06, 2020 at 07:01:50PM +0200, Alexandre Janniaux wrote:
> On Windows the swapchain might not be re-created automatically, which
> result in glitches when using the vk output. This enforce the creation
> of the swapchain as soon as the display size is changed.
>
> On Wayland, the size of the window is the size of the content so there
> is no automatic swapchain sizing and this call is mandatory.
> ---
>  modules/video_output/vulkan/display.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/modules/video_output/vulkan/display.c b/modules/video_output/vulkan/display.c
> index 174627d67d..283bd864bc 100644
> --- a/modules/video_output/vulkan/display.c
> +++ b/modules/video_output/vulkan/display.c
> @@ -351,6 +351,24 @@ static int Control(vout_display_t *vd, int query, va_list ap)
>      case VOUT_DISPLAY_CHANGE_ZOOM: {
>          vout_display_cfg_t cfg = *va_arg (ap, const vout_display_cfg_t *);
>          vout_display_PlacePicture(&sys->place, &vd->source, &cfg);
> +
> +        /* The following resize should be automatic on most platforms but can
> +         * trigger bugs on some platform with some drivers, that have been seen
> +         * on Windows in particular. Doing it right now enforce the correct
> +         * behavior and prevent these bugs.
> +         * In addition, platforms like Wayland need the call as the size of the
> +         * window is defined by the size of the content, and not the opposite.
> +         * The swapchain creation won't be done twice with this call. */
> +        if (query == VOUT_DISPLAY_CHANGE_DISPLAY_SIZE)
> +        {
> +            int width = (int) cfg.display.width;
> +            int height = (int) cfg.display.height;
> +            pl_swapchain_resize(sys->vk->swapchain, &width, &height);
> +
> +            if (width != (int) cfg.display.width
> +             || height != (int) cfg.display.height)
> +                return VLC_EGENERIC;
> +        }
>          return VLC_SUCCESS;
>      }
>
> --
> 2.26.0
>