[vlc-devel] [PATCH] Convert int to bool in Audio Bargraph

[Rémi Denis-Courmont]

Le perjantaina 10. huhtikuuta 2020, 19.09.15 EEST Vedanta Nayak a écrit :
> Hello,
> I have attached one patch instead of patching my patch.
> ---
>  modules/audio_filter/audiobargraph_a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/audio_filter/audiobargraph_a.c
> b/modules/audio_filter/audiobargraph_a.c index e744b52f24..ac87437038
> 100644
> --- a/modules/audio_filter/audiobargraph_a.c
> +++ b/modules/audio_filter/audiobargraph_a.c
> @@ -74,9 +74,9 @@ vlc_module_begin ()
> 
>      add_obsolete_string( CFG_PREFIX "address" )
>      add_obsolete_integer( CFG_PREFIX "port" )
> -    add_integer( CFG_PREFIX "bargraph", 1, BARGRAPH_TEXT,
> BARGRAPH_LONGTEXT, false ) // FIXME: this is a bool +    add_bool(
> CFG_PREFIX "bargraph", true, BARGRAPH_TEXT, BARGRAPH_LONGTEXT, false )
> add_integer( CFG_PREFIX "bargraph_repetition", 4, BARGRAPH_REPETITION_TEXT,
> BARGRAPH_REPETITION_LONGTEXT, false ) -    add_integer( CFG_PREFIX
> "silence", 1, SILENCE_TEXT, SILENCE_LONGTEXT, false ) // FIXME: this is a
> bool +    add_bool( CFG_PREFIX "silence", true, SILENCE_TEXT,
> SILENCE_LONGTEXT, false ) add_integer( CFG_PREFIX "time_window", 5000,
> TIME_WINDOW_TEXT, TIME_WINDOW_LONGTEXT, false ) add_float( CFG_PREFIX
> "alarm_threshold", 0.02, ALARM_THRESHOLD_TEXT, ALARM_THRESHOLD_LONGTEXT,
> false ) add_integer( CFG_PREFIX "repetition_time", 2000,
> REPETITION_TIME_TEXT, REPETITION_TIME_LONGTEXT, false )

It's rather suspicious that this change does not incur changes to read the 
variables in the code ?! And the description does *not* imply that this is 
fixing a mismatch.

-- 
Rémi Denis-Courmont
Hagalund ny stad, Nylands republik