[vlc-devel] [PATCH 1/4] fifo: cleanup

[Thomas Guillem]

On Mon, Apr 13, 2020, at 13:59, Rémi Denis-Courmont wrote:
> Le maanantaina 13. huhtikuuta 2020, 14.53.19 EEST Thomas Guillem a écrit :
> > On Mon, Apr 13, 2020, at 13:47, Rémi Denis-Courmont wrote:
> > > Le maanantaina 13. huhtikuuta 2020, 14.44.08 EEST Thomas Guillem a écrit :
> > > > On Mon, Apr 13, 2020, at 13:36, Rémi Denis-Courmont wrote:
> > > > > Le maanantaina 13. huhtikuuta 2020, 14.22.05 EEST Thomas Guillem a 
> écrit :
> > > > > > Hello,
> > > > > > 
> > > > > > This set was pushed without giving me the chance to review it.
> > > > > 
> > > > > Denis and I warned that the review deadlines were not going to work. I
> > > > > specifically warned that it should be one week for everyone to have
> > > > > fair
> > > > > time.
> > > > > 
> > > > > This was explicitly rejected.
> > > > 
> > > > I think we decided 72hours of workday.
> > > 
> > > No that's clearly not the case. I've seen plenty of commits getting
> > > through in less than that and mostly not from me.
> > 
> > Yes, I already made this mistake, more than one time, and you told me, with
> > a good reason, that it was not OK.
> > > It's 24 hours (now) or it's one week (like before).
> > 
> > 24 hours is impossible for me, specially with the new confinement situation.
> 
> You know, 24 hours is impossible for almost anyone, probably anyone in the 
> project, although it seems to be the working rule in Linux kernel somehow. The 
> point is that it's fair and it's reasonably fast to turn your patch series 
> around. As a committer, I find one week insanely long, and one day just about 
> right.

I can't review the weekend, and waiting 48H is better for me.
Indeed, with the confinement, I'm can't work full day since I'm keeping my baby at home.

You can do how it please you with this information. I don't think we will change any rules until we move to gitlab.

In the meantime, I will do my best to continue to review the ML daily (during the week) even if it's not always possible.

> 
> As a reviewer, I think one week is the minimum, unless everybody is full time 
> pro and in the same continent, in which case one or two business days. But VLC 
> is not such a case, and it probably never will be.
> 
> -- 
> Rémi Denis-Courmont
> Tapiolan uusi kaupunki, Uudenmaan tasavalta
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel