[vlc-devel] [PATCH v3 02/14] src: add cleaner md5 API

[Marvin Scholz]

On 13 Apr 2020, at 13:55, Rémi Denis-Courmont wrote:

> Le sunnuntaina 12. huhtikuuta 2020, 23.25.04 EEST Marvin Scholz a 
> écrit :
>> On 8 Apr 2020, at 19:07, Rémi Denis-Courmont wrote:
>>> Le keskiviikkona 8. huhtikuuta 2020, 19.47.54 EEST Marvin Scholz a 
>>> écrit :
>>>> On 8 Apr 2020, at 17:48, Rémi Denis-Courmont wrote:
>>>>> Le keskiviikkona 8. huhtikuuta 2020, 18.20.30 EEST Francois 
>>>>> Cartegnie
>>>>> a écrit
>>>>>
>>>>>> Le 08/04/2020 à 17:08, Rémi Denis-Courmont a écrit :
>>>>>>> And the FinishHex could be a static inline so as not to couple
>>>>>>> unrelated
>>>>>>> conversion and hashing routines.
>>>>>>
>>>>>> That will force a new include
>>>>>
>>>>> Sigh, fine then use a do-while(0) macro.
>>>>
>>>> Whats the benefit of a static inline function or a macro vs the way
>>>> I do it now?
>>>
>>> What François complained about - no need for extra #include
>>
>> I still don't really understand how I am supposed to do that…
>
> I don't have anything else to say. Maybe it's not possible or not 
> practical
> for reasons that would be clear if I tried, but I obviously haven't 
> and
> wouldn't care to.
>
>> And I still don't understand whats the benefit of doing that,
>> maybe I am misunderstanding something…
>
> Uh? As said, the benefit is that you don't need to include other 
> headers to get
> function declarations.
>

But you currently don't need that either with it being a VLC API, it 
would be a bit
nicer it being a static inline but this would force including the header 
indeed.

But with a macro, the caller has to somehow know they need to include 
the vlc_strings.h
to be able to use a vlc_hash_md5_FinishHex macro, which seems a bit 
weird…


> -- 
> Rémi Denis-Courmont
> Ville neuve de Tapiola, République d´Uusimaa
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel