[vlc-devel] [PATCH] Fixed type mismatch in bargraph filter

[Thomas Guillem]

Naup, we are talking about the BARGRAPH_TEXT, BARGRAPH_LONGTEXT, SILENCE_TEXT, and SILENCE_LONGTEXT texts.

On Tue, Apr 14, 2020, at 10:13, Vedanta Nayak wrote:
> Hello,
> Will this patch description suffice?
> 
> ---
>  modules/audio_filter/audiobargraph_a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/audio_filter/audiobargraph_a.c 
> b/modules/audio_filter/audiobargraph_a.c
> index e744b52f24..662793694f 100644
> --- a/modules/audio_filter/audiobargraph_a.c
> +++ b/modules/audio_filter/audiobargraph_a.c
> @@ -74,9 +74,9 @@ vlc_module_begin ()
>  
>      add_obsolete_string( CFG_PREFIX "address" )
>      add_obsolete_integer( CFG_PREFIX "port" )
> -    add_integer( CFG_PREFIX "bargraph", 1, BARGRAPH_TEXT, 
> BARGRAPH_LONGTEXT, false ) // FIXME: this is a bool
> +    add_bool( CFG_PREFIX "bargraph", true, BARGRAPH_TEXT, 
> BARGRAPH_LONGTEXT, false )
>      add_integer( CFG_PREFIX "bargraph_repetition", 4, 
> BARGRAPH_REPETITION_TEXT, BARGRAPH_REPETITION_LONGTEXT, false )
> -    add_integer( CFG_PREFIX "silence", 1, SILENCE_TEXT, 
> SILENCE_LONGTEXT, false ) // FIXME: this is a bool
> +    add_bool( CFG_PREFIX "silence", true, SILENCE_TEXT, 
> SILENCE_LONGTEXT, false ) 
>      add_integer( CFG_PREFIX "time_window", 5000, TIME_WINDOW_TEXT, 
> TIME_WINDOW_LONGTEXT, false )
>      add_float( CFG_PREFIX "alarm_threshold", 0.02, 
> ALARM_THRESHOLD_TEXT, ALARM_THRESHOLD_LONGTEXT, false )
>      add_integer( CFG_PREFIX "repetition_time", 2000, 
> REPETITION_TIME_TEXT, REPETITION_TIME_LONGTEXT, false )
> -- 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel