[vlc-devel] [PATCH 05/25] cpu: force feature support runtime check

[Rémi Denis-Courmont]

Le tiistaina 14. huhtikuuta 2020, 17.57.52 EEST Alexandre Janniaux a écrit :
> Hi,
> 
> On Tue, Apr 14, 2020 at 05:45:18PM +0300, Rémi Denis-Courmont wrote:
> > Le tiistaina 14. huhtikuuta 2020, 17.35.42 EEST Alexandre Janniaux a écrit 
:
> > > Hi,
> > > 
> > > Isn't vlc_CPU checked only in initialization steps to choose
> > > the correct variant?
> > 
> > No.
> 
> Can't we just remove the few case where it's not calling it
> during initialization?

You would still break dead code and IPA optimizations. And I don't even know 
any reasonable way to achieve what you describe.

All of this for what? You can't turn off at run-time features that you enabled 
at compile-time. This patch is completely counter-sensical.

-- 
Rémi Denis-Courmont
Ville neuve de Tapiola, République d´Uusimaa