[vlc-devel] [PATCH 2/2] include: strings: Add size check to vlc_hex_encode_binary

[Rémi Denis-Courmont]

Le perjantaina 17. huhtikuuta 2020, 16.08.11 EEST Marvin Scholz a écrit :
> On 17 Apr 2020, at 12:49, Rémi Denis-Courmont wrote:
> > Hi,
> > 
> > This warning has served me many times both to find bugs and to clean
> > code up.
> > 
> > If it triggers here, maybe the API should be improved...
> 
> It only triggers because the size argument is only used for the assert,
> alternatively I could use an if() and abort() so that it always checks
> it
> even for non-debug build. (Which might be better than to silently do a
> write out of bounds in non-debug cases).

I don't really see the point in having two size parameters when they are a 
function of each other.

-- 
Rémi Denis-Courmont
Tapiola new town, Uusimaan Republic