[vlc-devel] [PATCH] sout: add operations structure

Alexandre Janniaux ajanni at videolabs.io
Mon Apr 20 16:19:34 CEST 2020


It's not just for review, it's also for git history.

It certainly takes less time to write than writing an
answer to me on the mailing list, but it's not really my
problem if you don't do it, it doesn't involve neither my
code nor what I would have give to the project and I mostly
understand the reasons.

It's just very unwelcoming for new users and might lead to
removal of the code in a long term future because nobody
would understand the reason of the addition, as it refers
to nothing and doesn't explain the intent behind the change.

If you don't want to addres this, fine, I don't care, but
AFAICS you usually waste time here each time you don't want
to «waste time» writing a commit message, and it doesn't get
into an easy to find history of changes.

Alexandre Janniaux

On Mon, Apr 20, 2020 at 04:54:29PM +0300, Rémi Denis-Courmont wrote:
> Le maanantaina 20. huhtikuuta 2020, 14.49.19 EEST Alexandre Janniaux a écrit :
> > To me, having all the changes is not necessary, but it is
> > certainly helpful to have the reason why you will need this
> > in the commit message in that case.
> The only way that one wouldn't know is if one doesn't follow VLC development.
> I give zero credibility and have zero interest in reviews from such person (in
> this context).
> I'm spending the time to review the bug tracker and the mailing list
> regularly. I will *not* also spend the time to help people who can't be
> bothered to do likewise.
> --
> Rémi Denis-Courmont
> Ville neuve de Tapiola, République d´Uusimaa
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list