[vlc-devel] [PATCH] Fix for Boss key not working properly on full screen mode in linux

[Nicolas LEGOUEIX]

Hi
Sorry about the badly formed path submission. First timer here !
Here is the bug report : https://trac.videolan.org/vlc/ticket/21126
TL:DR is that in fullscreen mode on linux, pressing the boss key would not
minimize the window, only pause it. You had to press it twice in order to
get the expected result.
Should I re submit the fix with the additions you mentionned ?

Le lun. 20 avr. 2020 à 19:36, Alexandre Janniaux <ajanni at videolabs.io> a
écrit :

> Hi,
>
> Can you be more precise about the «not working» part? It works
> correctly here so I'm not sure of what you're fixing.
>
> Is it linked to a ticket too? You should reference the ticket
> in that case.
>
> Finally, you should not use From: like that.
>
> Put one author in From: (or in general, author of the commit)
> and the other in Co-authored-by: .
>
> Regards,
> --
> Alexandre Janniaux
> Videolabs
>
>
> On Mon, Apr 20, 2020 at 06:47:35PM +0200, nicolas.legoueix77 at gmail.com
> wrote:
> > From: Nicolas Legoueix and Yann Queric <nicolas.legoueix77 at gmail.com>
> >
> > ---
> >  modules/gui/qt/main_interface.cpp | 10 +++-------
> >  1 file changed, 3 insertions(+), 7 deletions(-)
> >
> > diff --git a/modules/gui/qt/main_interface.cpp
> b/modules/gui/qt/main_interface.cpp
> > index 259dcf7109..2968210bd4 100644
> > --- a/modules/gui/qt/main_interface.cpp
> > +++ b/modules/gui/qt/main_interface.cpp
> > @@ -1707,14 +1707,10 @@ void MainInterface::emitBoss()
> >  void MainInterface::setBoss()
> >  {
> >      THEMIM->pause();
> > -    if( sysTray )
> > -    {
> > +
> > +    showMinimized();
> > +    if(sysTray)
> >          hide();
> > -    }
> > -    else
> > -    {
> > -        showMinimized();
> > -    }
> >  }
> >
> >  void MainInterface::emitRaise()
> > --
> > 2.20.1
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200421/0cdcd233/attachment-0001.html>