[vlc-devel] [PATCH 1/7] apple: build: split tools and flags env vars

[Alexandre Janniaux]

Hi,

Yes, there: https://code.videolan.org/alexandre-janniaux/vlc/pipelines/16445

It failed for snap but this is related to packaging iiuc.

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, Apr 27, 2020 at 08:17:01AM +0200, Steve Lhomme wrote:
> OK for the contribs ones. I can't tell for the rest.
> Did you try it in the CI ?
>
> On 2020-04-24 17:04, Jean-Baptiste Kempf wrote:
> > OK for 1-7
> >
> > On Fri, Apr 24, 2020, at 17:01, Alexandre Janniaux wrote:
> > > CC is needed when calling `set_host_triplet` to compute the
> > > VLC_HOST_TRIPLET variable, so it must be set before.
> > > ---
> > >   extras/package/apple/build.sh | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > >
> > > diff --git a/extras/package/apple/build.sh b/extras/package/apple/build.sh
> > > index 3822f4b18e..f0f070948f 100755
> > > --- a/extras/package/apple/build.sh
> > > +++ b/extras/package/apple/build.sh
> > > @@ -299,7 +299,10 @@ set_host_envvars()
> > >       export OBJCFLAGS="$clike_flags"
> > >       export LDFLAGS="$VLC_DEPLOYMENT_TARGET_LDFLAG -arch $VLC_HOST_ARCH"
> > > +}
> > > +set_hosttools_envvar()
> > > +{
> > >       # Tools to be used
> > >       export CC="clang"
> > >       export CPP="clang -E"
> > > @@ -455,6 +458,9 @@ validate_sdk_name "$VLC_APPLE_SDK_NAME"
> > >   # Validate architecture argument
> > >   validate_architecture "$VLC_HOST_ARCH"
> > > +# Fetch tools, as CC is needed for set_host_triplet
> > > +set_hosttools_envvar
> > > +
> > >   # Set triplet (needs to be called after validating the arch)
> > >   set_host_triplet "$VLC_HOST_ARCH"
> > > --
> > > 2.26.1
> > >
> > > _______________________________________________
> > > vlc-devel mailing list
> > > To unsubscribe or modify your subscription options:
> > > https://mailman.videolan.org/listinfo/vlc-devel
> >
> > --
> > Jean-Baptiste Kempf -  President
> > +33 672 704 734
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> >
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel