[vlc-devel] [PATCH 1/3] libvlc: rename TitleChanged to TitleSelectionChanged

[Thomas Guillem]

On Tue, Apr 28, 2020, at 14:53, Hugo Beauzée-Luyssen wrote:
> On Tue, Apr 28, 2020, at 1:46 PM, Thomas Guillem wrote:
> > In 3.0, this event was sent for a new selection and for a new list.
> > 
> > RFC: Even if 4.0 break the API/ABI, I would prefer to not change the event enum
> > order. Indeed, libvlc is used by some languages that don't have enum and that
> > have to use a const int value for each of these enums.
> > ---
> >  include/vlc/libvlc_events.h | 5 +++--
> >  lib/media_player.c          | 4 ++--
> >  2 files changed, 5 insertions(+), 4 deletions(-)
> > 
> > diff --git a/include/vlc/libvlc_events.h b/include/vlc/libvlc_events.h
> > index 62a81104da..c901c8079d 100644
> > --- a/include/vlc/libvlc_events.h
> > +++ b/include/vlc/libvlc_events.h
> > @@ -104,7 +104,7 @@ enum libvlc_event_e {
> >      libvlc_MediaPlayerPositionChanged,
> >      libvlc_MediaPlayerSeekableChanged,
> >      libvlc_MediaPlayerPausableChanged,
> > -    libvlc_MediaPlayerTitleChanged,
> > +    libvlc_MediaPlayerDeprecated01, /* libvlc_MediaPlayerTitleChanged */
> >      libvlc_MediaPlayerSnapshotTaken,
> >      libvlc_MediaPlayerLengthChanged,
> >      libvlc_MediaPlayerVout,
> 
> Hi,
> 
> Wouldn't it be cleaner to use libvlc_MediaPlayerSnapshotTaken = 
> libvlc_MediaPlayerPausableChanged + 2 to avoid exposing a 
> libvlc_MediaPlayerDeprecated01 name?

Indeed, I will fix it.

> 
> Keeping the values as consistent as possible seems like a very good idea though
> 
> Regards,
> 
> -- 
>   Hugo Beauzée-Luyssen
>   hugo at beauzee.fr
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel