[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Martin Storsjö]

On Wed, 29 Apr 2020, Alexandre Janniaux wrote:

> It allows building the contrib with make directly, without needing to
> call the build script again or redefine the correct environment
> variables before.
> ---
> contrib/bootstrap                |  9 ++++++++
> extras/package/apple/build.sh    |  1 +
> extras/package/apple/symbols.mak | 37 ++++++++++++++++++++++++++++++++
> 3 files changed, 47 insertions(+)
> create mode 100644 extras/package/apple/symbols.mak

I don't really see how the commit message and the commit contents match up 
here - or I don't really understand what's going on.

What's symbols.mak, why hasn't that been needed before? The commit message 
talks about setting things (variables?) via makefiles instead of 
environment variables - I would expect it to be things like CC for the 
cross target and such, but then the commit tries to override autotools 
detections?

// Martin