[vlc-devel] [PATCH v2 14/17] contrib: vpx: allow compiling without bitcode

[Martin Storsjö]

On Wed, 29 Apr 2020, Alexandre Janniaux wrote:

> -fembed-bitcode might not be supported and we enable it through the
> --extra-cflags parameters like every other contribs.
> ---
> contrib/src/vpx/libvpx-remove-bitcode.patch | 17 +++++++++++++++++
> contrib/src/vpx/rules.mak                   |  1 +
> 2 files changed, 18 insertions(+)
> create mode 100644 contrib/src/vpx/libvpx-remove-bitcode.patch

Wouldn't this end up with the proper native builds missing bitcode as 
well? Or do we forcibly add -fembed-bitcode to CFLAGS in those cases, so 
we can live without vpx's buildsystem adding it themselves?

In that case the patch might be fine, but it would be good to clarify 
better (both in rules.mak and in the commit message) why it's ok to remove 
these flags here.

// Martin