[vlc-devel] [PATCH] modules: remove unneeded signal.h include

Steve Lhomme robux4 at ycbcr.xyz
Thu Apr 30 09:47:25 CEST 2020


Tested on all platforms
https://code.videolan.org/robUx4/vlc/pipelines/16727

The rationale is that on Windows CreateThread (which is allowed in UWP 
unlike _beginthreadex) is unsafe when using signal(). So I tracked the 
usage to make sure we don't use it when we build for UWP.

On 2020-04-30 9:44, Steve Lhomme wrote:
> ---
>   modules/access_output/file.c | 1 -
>   modules/control/rc.c         | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/modules/access_output/file.c b/modules/access_output/file.c
> index 036a0ceda65..9e7e5c2f6b8 100644
> --- a/modules/access_output/file.c
> +++ b/modules/access_output/file.c
> @@ -30,7 +30,6 @@
>   #endif
>   
>   #include <assert.h>
> -#include <signal.h>
>   #include <sys/types.h>
>   #include <fcntl.h>
>   #include <errno.h>
> diff --git a/modules/control/rc.c b/modules/control/rc.c
> index 8f7161ecd67..c992d000664 100644
> --- a/modules/control/rc.c
> +++ b/modules/control/rc.c
> @@ -30,7 +30,6 @@
>   #endif
>   
>   #include <errno.h>                                                 /* ENOMEM */
> -#include <signal.h>
>   #include <assert.h>
>   #include <math.h>
>   
> -- 
> 2.17.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list