[vlc-devel] [PATCH v2 15/17] apple: build: build gas-preprocessor for armv7

[Martin Storsjö]

On Thu, 30 Apr 2020, Alexandre Janniaux wrote:

> Hi,
>
> Thanks for review,
>
> I tried removing gas-preprocessor and there was issues with
> png (which were solvable) and ffmpeg failed with
> 
> WARNING: GNU assembler not found, install gas-preprocessor".

That sounds like something going wrong with the configure invocation - 
have a look in ffbuild/config.log around the area of testing the assembler 
capabilities.

If you're erroring out at this spot, the cherrypicks I mentioned won't 
probably help, but I can help with whatever other issues you run into 
regarding this.

I haven't tested building ffmpeg with the cross toolchain myself though, 
but in general, gas-preprocessor should be migrated into a thing of the 
past now.

> I haven't look into ffmpeg directly to be honest, but thank
> you for the information relative to gas-preprocessor.
>
> I'll take a look into the commits you gave, but in the mean
> time is it harmful to enable gas-preprocessor until this issue
> is fixed? It would allow enabling the armv7 CI and ensure only
> this change is needed in the long run.

It's not harmful in itself no, but it's something that shouldn't really be 
needed any longer, so any steps to activate it feels like a step in the 
wrong direction to me (even if the right direction requires more 
debugging). If it's temporary I don't want to block anything though.

// Martin