[vlc-devel] [PATCH 1/3] package/win32: build.sh: add options to do build with Universal Runtime

[Steve Lhomme]

On 2020-04-30 13:26, Steve Lhomme wrote:
> On 2020-04-30 12:47, Jean-Baptiste Kempf wrote:
>>
>>
>> On Thu, Apr 30, 2020, at 12:15, Steve Lhomme wrote:
>>> +if [ ! -z "$BUILD_UCRT" ]; then
>>> +    SHORTARCH="$SHORTARCH-ucrt"
>>> +    CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00
>>> -D_UNICODE -DUNICODE"
>>
>> Why? Those are forced by configure.ac
> 
> This is before building the contribs. There is no -enable-winstore in 
> those. But this line should be in the next patch (Winstore).

Actually, no. We should for Windows 10 to use the Universal CRT, even 
though it's possible to use it in Vista.

This documentation is not very clear
https://docs.microsoft.com/en-us/uwp/win32-and-com/win32-apis

It lists what DLL to use and from what version of Windows 10. But then 
it's possible to use the Universal CRT on Win8 and Win7.

https://support.microsoft.com/en-us/help/2999226/update-for-universal-c-runtime-in-windows

UNICODE may not be needed for non winstore versions, I will move it in 
my local patch.