[vlc-devel] [PATCH v2 1/3] package/win32: build.sh: add options to do build with Universal Runtime

[Jean-Baptiste Kempf]

On Thu, Apr 30, 2020, at 17:23, Steve Lhomme wrote:

> +CONTRIB_PREFIX=$TRIPLET
>  mkdir -p contrib/contrib-$SHORTARCH && cd contrib/contrib-$SHORTARCH
>  if [ ! -z "$WITH_PDB" ]; then
>      CONTRIBFLAGS="$CONTRIBFLAGS --enable-pdb"
> @@ -169,7 +192,17 @@ fi
>  if [ "$RELEASE" != "yes" ]; then
>       CONTRIBFLAGS="$CONTRIBFLAGS --disable-optim"
>  fi
> -${SCRIPT_PATH}/../../../contrib/bootstrap --host=$TRIPLET $CONTRIBFLAGS
> +if [ ! -z "$BUILD_UCRT" ]; then
> +    CONTRIB_PREFIX="${CONTRIB_PREFIX}ucrt"
> +    echo "EXTRA_CFLAGS=${CFLAGS}" >> config.mak
> +    echo "LDFLAGS=${LDFLAGS}" >> config.mak
> +    if [ ! "$COMPILING_WITH_CLANG" -gt 0 ]; then
> +        echo "CC=${CC}" >> config.mak
> +        echo "CXX=${CXX}" >> config.mak
> +    fi
> +fi

Sorry, but this whole part feels wrong: this is too much a special case, weirdly documented.
Why would the triplet and the install prefix be different here?

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734