[vlc-devel] [PATCH v2 1/7] contrib: Do not hardcode 32/64 bit

Thomas Guillem thomas at gllm.fr
Fri Aug 14 11:35:40 CEST 2020


Set LGTM (with your fixed patches).

On Thu, Aug 6, 2020, at 00:07, Marvin Scholz wrote:
> This was probably needed at the time of 32/64bit switchover but there
> should be no need to do this at all anymore. Additionally it breaks
> compiling for any non-x86_64 macOS that is not 32bit.
> ---
>  contrib/src/main.mak | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
> index 4ade7b799be..9f1d064c430 100644
> --- a/contrib/src/main.mak
> +++ b/contrib/src/main.mak
> @@ -131,16 +131,7 @@ endif
>  
>  ifdef HAVE_MACOSX
>  EXTRA_CXXFLAGS += -stdlib=libc++
> -ifeq ($(ARCH),x86_64)
> -EXTRA_CFLAGS += -m64
> -EXTRA_LDFLAGS += -m64
> -else
> -EXTRA_CFLAGS += -m32
> -EXTRA_LDFLAGS += -m32
> -endif
> -
>  XCODE_FLAGS += -arch $(ARCH)
> -
>  endif
>  
>  CCAS=$(CC) -c
> -- 
> 2.24.3 (Apple Git-128)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list