[vlc-devel] [vlc-commits] contrib: Do not hardcode 32/64 bit

[Marvin Scholz]

On 14 Aug 2020, at 16:28, David Fuhrmann wrote:

>> Am 14.08.2020 um 16:02 schrieb Marvin Scholz <git at videolan.org>:
>>
>> vlc | branch: master | Marvin Scholz <epirat07 at gmail.com> | Mon Jul 
>> 27 17:56:01 2020 +0200| [30f894b7d63bed8643b298af09064a1bc5e75c11] | 
>> committer: Marvin Scholz
>>
>> contrib: Do not hardcode 32/64 bit
>>
>> This was probably needed at the time of 32/64bit switchover but there
>> should be no need to do this at all anymore. Additionally it breaks
>> compiling for any non-x86_64 macOS that is not 32bit.
>>
>>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=30f894b7d63bed8643b298af09064a1bc5e75c11
>> ---
>>
>> contrib/src/main.mak | 9 ---------
>> 1 file changed, 9 deletions(-)
>>
>> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> index 4ade7b799b..9f1d064c43 100644
>> --- a/contrib/src/main.mak
>> +++ b/contrib/src/main.mak
>> @@ -131,16 +131,7 @@ endif
>>
>> ifdef HAVE_MACOSX
>> EXTRA_CXXFLAGS += -stdlib=libc++
>> -ifeq ($(ARCH),x86_64)
>> -EXTRA_CFLAGS += -m64
>> -EXTRA_LDFLAGS += -m64
>> -else
>> -EXTRA_CFLAGS += -m32
>> -EXTRA_LDFLAGS += -m32
>> -endif
>> -
>> XCODE_FLAGS += -arch $(ARCH)
>> -
>
> Hi Marvin,
>
> Thanks for the commit. One question: Can / should you do the same for 
> the macOS configure.sh?
>

Given that in configure.sh the check is done on the actual arch strings 
and only affects x86
it probably does not matter much there. But as we probably won't have 
any 32bit builds anyway,
we could probably remove it. We should probably keep the -march=core2 
-mtune=core2 for x86_64
as I guess it helps with performance optimizations the compiler can do?

> BR. David
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel